Pick-to: 1.1.0 Change-Id: I7b818025dd1684620f855dbd14b21d4c50481e23 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Improve logging for coreAPI notifications * Introduce `toString()` method for `QtWorkspaceConfigMessage` Change-Id: I7e82196ca641a93ea2a960230203fe21a38c8b4e Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
In the previous implementation, the extensions were using only one way to communicate with each other, which was getting a notification when a config value was set or changed. This was problematic on startup because there was no order in which the extensions were activated and when messages were handled. b5bf26ac084823758be18453bb61579fefceb57c partially fixed this issue by adding a way to wait for `qt-cpp` to be ready, but it was still not enough. The extension should read config values when they are ready, not when messages are sent from other extensions. Remove the `lazy` initialization parameter in `Project` classes. Instead of using that parameter, we remove the firing event from `addProject()` and only fire when the project is added after startup. This way, we don't need the `lazy` parameter anymore. Since `processMessage()` is not used during startup, this commit also fixes QTBUG-131702 on the extension side. qt-lib: This commit changes `QtWorkspaceConfigMessage` and removes values in it. `QtWorkspaceConfigMessage` is now used only to notify that a value or values were set. The value `CoreApi` can be accessed by `getValue` and `setValue`. * Update the `CoreApi` interface * Add `setValue` * Rename `update` to `notify` * Remove `get<T>()` from `QtWorkspaceConfigMessage` qt-core: * Remove the internal checking mechanism to understand if a value was set or changed. Instead, just store values. qt-cpp: * Update `processMessage()` for the new usage. * Initialize config values explicitly during startup. qt-qml: * Update `processMessage()` for the new usage. * Separate starting `qmlls` from the constructor. It should be started when the conditions are met. * Get config values and update parameters inside `onProjectAdded()` Task-number: QTBUG-131702 Change-Id: If9831ea1257d123f777e6ae2afb92f33942dd3da Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
We were sending `setRecommendedSettings` telemetry every time it is registered, we should only send it when the user calls the command. Pick-to: 1.1.0 Change-Id: I55a10163dee2f491ffc218be85ef101872fde8ce Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io> Reviewed-by: Ben Cho <ben.cho@qt.io>
Change-Id: Iab1c9f545d8b10ad13127a3a77545a3f4f475597 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Change-Id: Iee27c1a53bc63bbfd7f3b11f90cfacc549810d76 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
In the current implementation, when multi-root workspaces are used, the config values for other extensions are not set when a project is added. This causes not to generate cmake kits and set wrong qmlls parameters. Change-Id: I669406cf304f21e21fce9a6e459285021e467d2f Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Since 3968bcb7b59e522f328496cc56b427fde75c79d2 switched the default generator from `Ninja Multi-Config` to `Ninja`, it is useful to have the build directory with the build type in the recommended settings. Change-Id: Id7d192340a390834d38f1e399674f22fc4b71895 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Since event handlers are not disposed properly, they are still active when the project is closed. This can cause those handlers to be called after the project is closed, which can lead to errors. * Dispose project managers inside `Deactivate()` Change-Id: Idd7b8548f7c16c41c0e4fd7052fa7ae988678bc4 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
https: //www.typescriptlang.org/tsconfig/#incremental Change-Id: I750398a09178e02c3b3c73bf8e8fc7654dab03d4 Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>